Skip to content

fix(core): restack OriginWeave protocol version binding - #241

Draft
seonghobae wants to merge 8 commits into
feat/browser-protocol-capability-requirementfrom
feat/originweave-protocol-version-binding
Draft

fix(core): restack OriginWeave protocol version binding#241
seonghobae wants to merge 8 commits into
feat/browser-protocol-capability-requirementfrom
feat/originweave-protocol-version-binding

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Buyer/foundation repair

The protocol-generation binding originally reviewed in merged PR #108 was no longer present in the current #107 tree after the parent branch was reconstructed onto its moved prerequisite. Historical #108 is therefore lineage-only evidence. This Draft restores the missing production boundary on the current canonical #107 base and now also makes the browser protocol family itself an explicit fail-closed requirement.

Exact stack truth

Keep Draft while #107 remains active. Predecessor checks/reviews do not transfer to this exact head.

Restored and strengthened contract

BrowserProtocolAdapterDescriptor records OriginWeaveProtocolVersion independently from adapter, WebDriver BiDi/CDP, and browser revisions. Exact generation mismatch fails closed with typed BrowserProtocolVersionRequirementError.

The descriptor now also exposes require_kind(BrowserProtocolKind). WebDriver BiDi and Chrome DevTools Protocol are never treated as interchangeable: an exact family match succeeds, while a mismatch returns typed BrowserProtocolKindRequirementError::ProtocolKindMismatch { required, actual }. The regression verifies the stable, source-free error contract. This is metadata/dispatch validation only; it grants no browser/session/origin/action/network authority and adds no cross-protocol fallback.

Test-first evidence

RED head 532150a6a3870e5479817d86d92b98c5545c7455 was checked out by hosted CI and failed exactly because BrowserProtocolKindRequirementError and require_kind did not exist. The repair was then implemented on this same canonical branch.

For unchanged GREEN head 32c0c7d488d7f644b8151cc142522f0cba4c64eb:

  • repository-native CI run 33245039530: success;
  • Rust contracts job 99080970474: formatting, workspace check, full tests, strict Clippy, and API documentation all success;
  • Production coverage in the same CI run completed successfully;
  • Manifest V3 Compatibility run 33245039472: success.

No predecessor, synthetic, model-only, status-only, skipped, or historical result is promoted to current-head evidence.

Authority boundary

This changes no browser I/O, authority grant, network/TLS/HTTP behavior, unrestricted JavaScript surface, secret handling, workflow, or release policy. Protected-main AGENTS.md remains authoritative. This scheduled writer does not merge, self-approve, force-push, destructively rebase, alter workflows/rulesets/secrets, weaken checks, tag, release, or publish.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae mentioned this pull request Aug 28, 2026
Draft
@seonghobae

seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Restacked non-destructively on PR #107 exact head fa84bb660ece2b746c61e32eecec2fde6c8c4dd8; new exact head is c4fb2931f8fa4bd2000aaedf1d3aaa5e4603897d. The semantic diff remains limited to exact OriginWeave protocol-version/family binding and its tests. Local verification: 152 Python contracts, full locked workspace tests, fmt, strict Clippy, rustdoc, and fresh-worktree LLVM function/line/region/branch coverage all pass at 100%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working priority: medium type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@seonghobae